Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Build task will not compile bundles modules and it's sub-modules. #5473

Closed
yuqi1129 opened this issue Nov 5, 2024 · 0 comments · Fixed by #5479
Closed

[Improvement] Build task will not compile bundles modules and it's sub-modules. #5473

yuqi1129 opened this issue Nov 5, 2024 · 0 comments · Fixed by #5479
Assignees
@yuqi1129
Labels
0.7.0 Release v0.7.0 improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Nov 5, 2024

What would you like to be improved?

Remove the module from the CI-Ignore file to trigger a build task if any changes are made to the module.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Nov 5, 2024
@yuqi1129 yuqi1129 mentioned this issue Nov 6, 2024
Merged
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Nov 6, 2024
github-actions bot pushed a commit that referenced this issue Nov 6, 2024
@yuqi1129 @web-flow
[#5473] improvement(CI): Change CI build file to add bundles files in…
3d5894c 
…to the build task. (#5479)

### What changes were proposed in this pull request?


Add the bundles and their sub-modules to the changes listening list. 

### Why are the changes needed?

Bundles are newly added modules and should be added to the changes
listening list.

Fix: #5473 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI.
@github-actions github-actions bot mentioned this issue Nov 6, 2024
Merged
jerryshao pushed a commit that referenced this issue Nov 6, 2024
@github-actions @yuqi1129
[#5473] improvement(CI): Change CI build file to add bundles files in…
cccda18 
…to the build task. (#5485)

### What changes were proposed in this pull request?


Add the bundles and their sub-modules to the changes listening list. 

### Why are the changes needed?

Bundles are newly added modules and should be added to the changes
listening list.

Fix: #5473 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI.

Co-authored-by: Qi Yu <[email protected]>
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@yuqi1129 @mplmoknijb
[apache#5473] improvement(CI): Change CI build file to add bundles fi…
6cfe24e 
…les into the build task. (apache#5479)

### What changes were proposed in this pull request?


Add the bundles and their sub-modules to the changes listening list. 

### Why are the changes needed?

Bundles are newly added modules and should be added to the changes
listening list.

Fix: apache#5473 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
0.7.0 Release v0.7.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
2 participants
@jerryshao @yuqi1129