-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.pyiceberg.yaml config files should be loaded from current dir instead of home folder #1333
Comments
that's an interesting use case. what do you think about this search order?
Or do you think the order should be reversed? |
It should check the current dir first since it is the most specific e.g. then you could use the global home dir file for most things but override that on a particular project with a project-local config file instead |
Aren't you afraid of checking in credentials? |
true I probably wouldn't check it in but I'd never put it in my home folder either way, it seems like a project file |
It is inspired by how AWS handles credentials in That said, I'm not against adding the current directory as the last fallback. Are you interested in adding this to the codebase? |
Feature Request / Improvement
https://py.iceberg.apache.org/configuration/#catalogs
I don't want a global iceberg config for my whole machine, I want a file that lives in my project directory that could be potentially checked into git
there is already a search order and fall-back logic for home dir vs
PYICEBERG_HOME
env valuehttps://github.com/apache/iceberg-python/blob/main/pyiceberg/utils/config.py#L69-L74
...so it just needs to do the logical thing and try the current working dir before either of those
The text was updated successfully, but these errors were encountered: