Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Package names com.taobao.* and com.alibaba.*? #2148

Closed
janpio opened this issue Feb 21, 2019 · 4 comments
Closed

[Android] Package names com.taobao.* and com.alibaba.*? #2148

janpio opened this issue Feb 21, 2019 · 4 comments

Comments

@janpio
Copy link
Member

janpio commented Feb 21, 2019

When looking at PR #2071 I noticed that the Android package names include com.taobao and com.alibaba.

Is this here to stay or will this be updated to org.apache.*?

@janpio janpio changed the title [Android] Package names com.taobao and com.alibaba? [Android] Package names com.taobao.* and com.alibaba.*? Feb 21, 2019
@YorkShen
Copy link
Contributor

YorkShen commented Feb 22, 2019

This is a problem I want to solve years ago.

But as there are many util class or base class under com.taobao and com.alibaba package, such as com.taobao.weex.ui.component.WXComponent, which is the base class for almost every UI component.

If we change the package name directly to org.apache.*, users with custom plugins that extends the base class like com.taobao.weex.ui.component.WXComponent or uses the util class will have many problems when updating to the latest version, as the package renaming will cause lots of compiling issue.

Any advice on reducing the cost of renaming for Weex users?

@janpio
Copy link
Member Author

janpio commented Feb 22, 2019

I honestly don't know much about Android development.

Is there a way to maybe rename the real classes but keep an "alias" with the old name around so plugin can keep working?

@YorkShen
Copy link
Contributor

YorkShen commented Feb 25, 2019

Is there a way to maybe rename the real classes but keep an "alias" with the old name around so plugin can keep working?

Sadly, no.

As there is no way to avoid the backwards compatibility issue now, I think maybe we should keep it untouched until have a better solution.

@YorkShen YorkShen self-assigned this Feb 26, 2019
@YorkShen YorkShen removed their assignment May 17, 2019
@cnryb
Copy link
Member

cnryb commented Dec 12, 2019

The package name has been changed to org.apache. *

@cnryb cnryb closed this as completed Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants