From 6b7c65d0c319130a1b76ef99035a7da38685fabd Mon Sep 17 00:00:00 2001 From: Andrei Lisnic Date: Mon, 14 Mar 2022 11:02:21 +0200 Subject: [PATCH] Update readme and workflow --- .github/workflows/ruby.yml | 2 ++ DEVELOPMENT.md | 16 ++++++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 0088d83..8fe1b04 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -32,5 +32,7 @@ jobs: run: (cd spec/rails5; bundle install; yard gems) - name: Install Rails 6 deps run: (cd spec/rails6; bundle install; yard gems) + - name: Install Rails 7 deps + run: (cd spec/rails7; bundle install; yard gems) - name: Run tests run: bundle exec rspec diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 2a1cd68..59b3a7d 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -19,8 +19,16 @@ $ bundle install && yard gems $ cd ../../ ``` -4. now tests should pass locally and you can try different changes -5. sumbit PR + +4. install dummy rails7 app deps and build its yard cache + + ``` + $ cd spec/rails7 + $ bundle install && yard gems + $ cd ../../ + ``` +5. now tests should pass locally and you can try different changes +6. sumbit PR ## Completion coverage tracking @@ -74,10 +82,10 @@ In case of option 2, don't forget to remove the flag after yml file has been upd In case a new set of assertion files has to be created (for a new Rails version for example), a script can be used - https://github.com/iftheshoefritz/solargraph-rails/blob/master/script/generate_definitions.rb. -All you have to do is to go to the same Rails app root, and execute the script: +All you have to do is execute the script and pass it a path to rails app: ``` -ruby path/to/generate_definitions.rb +ruby script/generate_definitions.rb spec/rails6 ``` Make sure to review the script and uncomment relevant parts