-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide esm version #257
Comments
@tobiasdiez yeah, I think we knew this should happen eventually - thanks for the nudge. Got a PR open for it. I'll test out the builds next week, should be able to get it merged and published in a number of days. If you don't mind trying out the builds that would be great! |
Hey @tobiasdiez I'd like to nudge again. this fix would cut 100kb from my app bundle size. Thank you |
@floydspace the changes on the linked PR take after Apollo Server's approach, which has been updated once already and is awaiting another fix from a contributor who has offered to implement the change. I'd like to wait until that change lands, then I can follow up with an equivalent update on #259. |
Hey @trevor-scheer, I see that the other fix is not really moving for quite a while. Any chance we can get the ball running on this one? |
My #259 PR follows Apollo Server's pattern. I don't think Apollo Server has it right currently, so I'm reluctant to adopt the same pattern until we figure out the right one. I unfortunately haven't had time to investigate this and I'm not sure when that might happen. If anyone feels motivated to solve the TS + CJS/ESM dual-package problem in a monorepo I would love to see that. The results of my limited investigation up to this point are documented in the linked issue. There's potentially some tooling that could help us there if we bend it to our will but I haven't tried anything out yet. |
With more and more build tools (vite, nuxt, etc) going towards an esm-first build, it would be nice if a proper esm interface could be provided, i.e. transpile and distribute esm version, including correct export declaration in
package.json
.The text was updated successfully, but these errors were encountered: