Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the List Item ADS component to Entity List item #37620

Closed
11 of 12 tasks
Tracked by #37342
ankitakinger opened this issue Nov 21, 2024 · 2 comments · Fixed by #38344
Closed
11 of 12 tasks
Tracked by #37342

Update the List Item ADS component to Entity List item #37620

ankitakinger opened this issue Nov 21, 2024 · 2 comments · Fixed by #38344
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Nov 21, 2024 •
edited
Loading

This component will be reusable all over the product, within different IDEs, to show the entity item in a list of entities along with its core functionalities.

Props that would be needed for the Entity List item:

  • leftControl - A react node that can be just an icon, or an icon button as needed.
  • title - string
  • rightControl - A react node that can be just an icon, or an icon button, or a context menu as needed.
  • rightControlVisibility - hover | always (contextMenu is seen only on hover)
  • onClick - For navigating to item
  • description - string
  • descriptionType - inline | block (should fit in 1 line only)

Notes:

  1. Collapsible will not be part of entity item component.
  2. Error state for entity item - when response errors - out of scope
  3. Max width for description - yet to be finalized
  4. Libraries & Package versioning would be separate custom implementations
  5. Replacing of current implementation will not be a part of this task.

Support the following states:

  • Default
  • Focus
  • Disabled
  • Hover
  • Active

Design:
https://www.figma.com/design/sz08OJt2VrEgxQ8eToFIqG/ADS2.0---Components?node-id=8954-7244&t=HrFzlJnYdgkRxcwN-0
@ankitakinger ankitakinger mentioned this issue Nov 21, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 21, 2024
@ankitakinger ankitakinger changed the title Refactor current Entity implementations (or create new) to work without pageId and across different IDEs Refactor current Entity implementations (or create new) to work without pageId and across different IDEs Nov 21, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE Needs Design needs design or changes to design labels Nov 21, 2024
@ankitakinger ankitakinger changed the title Refactor current Entity implementations (or create new) to work without pageId and across different IDEs Refactor current Entity implementations (or create new) to work without pageId Nov 27, 2024
@ankitakinger ankitakinger removed the Needs Design needs design or changes to design label Dec 2, 2024
@ankitakinger ankitakinger changed the title Refactor current Entity implementations (or create new) to work without pageId Create a new ADS component for Entity List item Dec 2, 2024
@ankitakinger ankitakinger changed the title Create a new ADS component for Entity List item Update the List Item ADS component to Entity List item Dec 20, 2024
@ankitakinger
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @hetunandu

@ankitakinger
Copy link
Contributor Author

Not completing the focus state i this task, as this should be handled in the task where all ADS items will get the focus ring styles.

@ankitakinger ankitakinger self-assigned this Dec 23, 2024
@ankitakinger ankitakinger mentioned this issue Dec 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
2 participants
@Nikhil-Nandagopal @ankitakinger