From 0dea8eb78b7f21265e3599c35721518ba5913239 Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Thu, 18 Jan 2024 11:04:09 +0530 Subject: [PATCH 1/5] chore: Add Maximize and Minimize icons for Side by Side --- packages/design-system/src/Icon/Icon.provider.tsx | 8 ++++++++ .../design-system/src/__assets__/icons/ads/maximize.svg | 6 ++++++ .../design-system/src/__assets__/icons/ads/minimize.svg | 4 ++++ 3 files changed, 18 insertions(+) create mode 100644 packages/design-system/src/__assets__/icons/ads/maximize.svg create mode 100644 packages/design-system/src/__assets__/icons/ads/minimize.svg diff --git a/packages/design-system/src/Icon/Icon.provider.tsx b/packages/design-system/src/Icon/Icon.provider.tsx index 4ab1bc8c..82e7a6b3 100644 --- a/packages/design-system/src/Icon/Icon.provider.tsx +++ b/packages/design-system/src/Icon/Icon.provider.tsx @@ -589,6 +589,12 @@ const InviteUserIcon = importSvg( const ManageIcon = importSvg( () => import("../__assets__/icons/ads/manage.svg"), ); +const MaximizeIcon = importSvg( + () => import("../__assets__/icons/ads/maximize.svg"), +); +const MinimizeIcon = importSvg( + () => import("../__assets__/icons/ads/minimize.svg"), +); const ArrowLeft = importSvg( () => import("../__assets__/icons/ads/arrow-left.svg"), ); @@ -1308,7 +1314,9 @@ const ICON_LOOKUP = { login: LoginIcon, logout: LogoutIcon, manage: ManageIcon, + maximize: MaximizeIcon, member: UserHeartLineIcon, + minimize: MinimizeIcon, minus: RemoveIcon, module: ModuleIcon, mobile: MobileIcon, diff --git a/packages/design-system/src/__assets__/icons/ads/maximize.svg b/packages/design-system/src/__assets__/icons/ads/maximize.svg new file mode 100644 index 00000000..17be9e46 --- /dev/null +++ b/packages/design-system/src/__assets__/icons/ads/maximize.svg @@ -0,0 +1,6 @@ + + + + + + diff --git a/packages/design-system/src/__assets__/icons/ads/minimize.svg b/packages/design-system/src/__assets__/icons/ads/minimize.svg new file mode 100644 index 00000000..bcec2ab5 --- /dev/null +++ b/packages/design-system/src/__assets__/icons/ads/minimize.svg @@ -0,0 +1,4 @@ + + + + From 330b1c0bc515d5f727c4663ad60fcd953f008be1 Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Fri, 19 Jan 2024 15:29:20 +0530 Subject: [PATCH 2/5] update icons --- .../src/__assets__/icons/ads/maximize.svg | 10 +++++----- .../src/__assets__/icons/ads/minimize.svg | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/design-system/src/__assets__/icons/ads/maximize.svg b/packages/design-system/src/__assets__/icons/ads/maximize.svg index 17be9e46..99584615 100644 --- a/packages/design-system/src/__assets__/icons/ads/maximize.svg +++ b/packages/design-system/src/__assets__/icons/ads/maximize.svg @@ -1,6 +1,6 @@ - - - - - + + + + + diff --git a/packages/design-system/src/__assets__/icons/ads/minimize.svg b/packages/design-system/src/__assets__/icons/ads/minimize.svg index bcec2ab5..84eb5169 100644 --- a/packages/design-system/src/__assets__/icons/ads/minimize.svg +++ b/packages/design-system/src/__assets__/icons/ads/minimize.svg @@ -1,4 +1,4 @@ - - - + + + From df8623a1f62ed00f33b64605dd01ece1dba0b28c Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Fri, 19 Jan 2024 16:36:44 +0530 Subject: [PATCH 3/5] update icons --- .../src/__assets__/icons/ads/maximize.svg | 10 +++++----- .../src/__assets__/icons/ads/minimize.svg | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/design-system/src/__assets__/icons/ads/maximize.svg b/packages/design-system/src/__assets__/icons/ads/maximize.svg index 99584615..0819c712 100644 --- a/packages/design-system/src/__assets__/icons/ads/maximize.svg +++ b/packages/design-system/src/__assets__/icons/ads/maximize.svg @@ -1,6 +1,6 @@ - - - - - + + + + + diff --git a/packages/design-system/src/__assets__/icons/ads/minimize.svg b/packages/design-system/src/__assets__/icons/ads/minimize.svg index 84eb5169..76932ad0 100644 --- a/packages/design-system/src/__assets__/icons/ads/minimize.svg +++ b/packages/design-system/src/__assets__/icons/ads/minimize.svg @@ -1,4 +1,4 @@ - - - + + + From b6a4c1dee4a33c2f30f35304c077012808d8c0ae Mon Sep 17 00:00:00 2001 From: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Date: Fri, 19 Jan 2024 16:43:42 +0530 Subject: [PATCH 4/5] feat: icon fill set to current color --- .../design-system/src/__assets__/icons/ads/maximize.svg | 8 ++++---- .../design-system/src/__assets__/icons/ads/minimize.svg | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/design-system/src/__assets__/icons/ads/maximize.svg b/packages/design-system/src/__assets__/icons/ads/maximize.svg index 0819c712..fa58930a 100644 --- a/packages/design-system/src/__assets__/icons/ads/maximize.svg +++ b/packages/design-system/src/__assets__/icons/ads/maximize.svg @@ -1,6 +1,6 @@ - - - - + + + + diff --git a/packages/design-system/src/__assets__/icons/ads/minimize.svg b/packages/design-system/src/__assets__/icons/ads/minimize.svg index 76932ad0..fc065554 100644 --- a/packages/design-system/src/__assets__/icons/ads/minimize.svg +++ b/packages/design-system/src/__assets__/icons/ads/minimize.svg @@ -1,4 +1,4 @@ - - + + From b8cf1dc46788fc3894cd51678b1b8cd578f7cf6b Mon Sep 17 00:00:00 2001 From: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Date: Fri, 19 Jan 2024 16:44:18 +0530 Subject: [PATCH 5/5] Create khaki-onions-applaud.md --- .changeset/khaki-onions-applaud.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/khaki-onions-applaud.md diff --git a/.changeset/khaki-onions-applaud.md b/.changeset/khaki-onions-applaud.md new file mode 100644 index 00000000..c27362f2 --- /dev/null +++ b/.changeset/khaki-onions-applaud.md @@ -0,0 +1,5 @@ +--- +"@appsmithorg/design-system": patch +--- + +chore: Add Maximize and Minimize icons for Side by Side