diff --git a/src/interpolation/details/ArborX_InterpDetailsSymmetricPseudoInverseSVD.hpp b/src/interpolation/details/ArborX_DetailsSymmetricSVD.hpp similarity index 97% rename from src/interpolation/details/ArborX_InterpDetailsSymmetricPseudoInverseSVD.hpp rename to src/interpolation/details/ArborX_DetailsSymmetricSVD.hpp index 2c276996d..9e3bd6992 100644 --- a/src/interpolation/details/ArborX_InterpDetailsSymmetricPseudoInverseSVD.hpp +++ b/src/interpolation/details/ArborX_DetailsSymmetricSVD.hpp @@ -9,8 +9,8 @@ * SPDX-License-Identifier: BSD-3-Clause * ****************************************************************************/ -#ifndef ARBORX_INTERP_DETAILS_SYMMETRIC_PSEUDO_INVERSE_SVD_HPP -#define ARBORX_INTERP_DETAILS_SYMMETRIC_PSEUDO_INVERSE_SVD_HPP +#ifndef ARBORX_DETAILS_SYMMETRIC_SVD_HPP +#define ARBORX_DETAILS_SYMMETRIC_SVD_HPP #include #include @@ -18,7 +18,7 @@ #include #include -namespace ArborX::Interpolation::Details +namespace ArborX::Details { template @@ -246,6 +246,6 @@ KOKKOS_FUNCTION void symmetricPseudoInverseSVDKernel(Matrix &mat, Diag &diag, } } -} // namespace ArborX::Interpolation::Details +} // namespace ArborX::Details #endif diff --git a/src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp b/src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp index b76ce3d37..a1f9ec5d9 100644 --- a/src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp +++ b/src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp @@ -14,11 +14,11 @@ #include #include +#include #include #include #include #include -#include #include #include @@ -110,7 +110,8 @@ class MovingLeastSquaresCoefficientsKernel // We need the inverse of P^T.PHI.P, and because it is symmetric, we can use // the symmetric SVD algorithm to get it. - symmetricPseudoInverseSVDKernel(moment, svd_diag, svd_unit); + ::ArborX::Details::symmetricPseudoInverseSVDKernel(moment, svd_diag, + svd_unit); // Now, the moment has [P^T.PHI.P]^-1 // Finally, the result is produced by computing p(0).[P^T.PHI.P]^-1.P^T.PHI diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 6a5e426c2..3dbb8b0b9 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -49,6 +49,7 @@ add_executable(ArborX_Test_DetailsUtils.exe tstAttachIndices.cpp tstDetailsVector.cpp tstDetailsUtils.cpp + tstDetailsSVD.cpp tstDetailsKokkosExtStdAlgorithms.cpp tstDetailsKokkosExtKernelStdAlgorithms.cpp tstDetailsKokkosExtUninitializedMemoryAlgorithms.cpp @@ -262,7 +263,6 @@ target_compile_definitions(ArborX_Test_BoostAdapters.exe PRIVATE BOOST_TEST_DYN_ add_test(NAME ArborX_Test_BoostAdapters COMMAND ArborX_Test_BoostAdapters.exe) add_executable(ArborX_Test_InterpMovingLeastSquares.exe - tstInterpDetailsSVD.cpp tstInterpDetailsCompactRadialBasisFunction.cpp tstInterpDetailsPolyBasis.cpp tstInterpDetailsMLSCoefficients.cpp diff --git a/test/tstInterpDetailsSVD.cpp b/test/tstDetailsSVD.cpp similarity index 95% rename from test/tstInterpDetailsSVD.cpp rename to test/tstDetailsSVD.cpp index cf6b96cd2..9f54f5f2e 100644 --- a/test/tstInterpDetailsSVD.cpp +++ b/test/tstDetailsSVD.cpp @@ -11,7 +11,7 @@ #include "ArborX_EnableDeviceTypes.hpp" #include "ArborX_EnableViewComparison.hpp" -#include +#include #include "BoostTest_CUDA_clang_workarounds.hpp" #include @@ -45,7 +45,7 @@ void makeCase(ExecutionSpace const &exec, Value const (&src_arr)[M][N][N], Kokkos::parallel_for( "Testing::run_svd", Kokkos::RangePolicy(exec, 0, 1), KOKKOS_LAMBDA(int) { - ArborX::Interpolation::Details::symmetricSVDKernel(inv, diag, unit); + ArborX::Details::symmetricSVDKernel(inv, diag, unit); for (int p = 0; p < N; ++p) for (int q = 0; q < N; ++q) { @@ -61,8 +61,7 @@ void makeCase(ExecutionSpace const &exec, Value const (&src_arr)[M][N][N], Kokkos::parallel_for( "Testing::run_inverse", Kokkos::RangePolicy(exec, 0, 1), KOKKOS_LAMBDA(int) { - ArborX::Interpolation::Details::symmetricPseudoInverseSVDKernel( - inv, diag, unit); + ArborX::Details::symmetricPseudoInverseSVDKernel(inv, diag, unit); }); ARBORX_MDVIEW_TEST_TOL(ref, inv, Kokkos::Experimental::epsilon_v); }