Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_primary_descriptor_from_nodes() aware of which descriptor (name, map_popup, description) #10299

Closed
jacobtylerwalls opened this issue Nov 28, 2023 · 1 comment
Assignees

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Nov 28, 2023

Arches for Science has a use case for overriding AbstractPrimaryDescriptorsFunction.get_primary_descriptor_from_nodes() to read a calculated value from the db instead of running python logic to calculate a descriptor from scratch. To do that, the function needs knowledge of which descriptor's configuration was passed in, e.g. "map_popup", "name", or "description".

See the use case here:

@chiatt We should consider patching this in Arches 7.5. As it stands, this function has no knowledge of what descriptor was passed in (which we need if we want to be able to read the JSON field from the db and look up the given descriptor by key).

Originally posted by @jacobtylerwalls in archesproject/arches-for-science#1452 (comment)

@jacobtylerwalls
Copy link
Member Author

Fixed in #10300

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Dec 4, 2023
jacobtylerwalls added a commit that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant