Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 21219 Honour ARGOCD_APPLICATIONSET_CONTROLLER_NAMESPACES for all ApplicationSet events #21241

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: 21219 Honour ARGOCD_APPLICATIONSET_CONTROLLER_NAMESPACES for all ApplicationSet events #21241

wants to merge 7 commits into from
+86 −5

Conversation

eadred
Copy link
Contributor

@eadred eadred commented Dec 18, 2024 •
edited
Loading

Namespace filtering is applied to Update, Delete and Generic events.

Fixes #21219

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@eadred
fix: 21219 Honour ARGOCD_APPLICATIONSET_CONTROLLER_NAMESPACES for all…
b171dcf 
… ApplicationSet events

Namespace filtering is applied to Update, Delete and Generic events.

Fixes argoproj#21219

Signed-off-by: eadred <[email protected]>
@eadred eadred requested a review from a team as a code owner December 18, 2024 14:55
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 18, 2024 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@crenshaw-dev
Copy link
Member

Change makes sense to me! Could you write a test?

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (f15e1bc) to head (acb06fc).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21241      +/-   ##
==========================================
- Coverage   55.23%   55.17%   -0.06%     
==========================================
  Files         337      337              
  Lines       57055    57054       -1     
==========================================
- Hits        31515    31482      -33     
- Misses      22847    22877      +30     
- Partials     2693     2695       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eadred
Copy link
Contributor Author

eadred commented Dec 19, 2024

I'm not quite sure what the failing unit test has to do with these changes.

@eadred
Copy link
Contributor Author

eadred commented Dec 20, 2024

PR #21271 attempts to fix the unrelated data race test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Status: Ready for final review
Milestone
No milestone
3 participants
@eadred @crenshaw-dev @andrii-korotkov-verkada