Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidy up Grafana dashboard #21265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dee-kryvenko
Copy link

@dee-kryvenko dee-kryvenko commented Dec 19, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

There was a few issues with the dashboard, not sure how no one caught this before... queries are mismatched i.e. Application Controller is pulling up Server metrics etc. I also mover gRPC to a separate collapsible panel, most of the time they would not be enabled and when they are - it takes a while to query. If I just want server metrics along with no gRPC, I should not have to wait... I fixed Application Controller panels, they would show up namespace as a legend for some reason - not sure what was the intent with that.. it now uses pod names. Lastly, I moved legend to a tooltip so it does not clatter the screen, now that instead of namespaces we are looking at pod names which are longer.

Signed-off-by: Dee Kryvenko <[email protected]>
Signed-off-by: Dee Kryvenko <[email protected]>
Signed-off-by: Dee Kryvenko <[email protected]>
Signed-off-by: Dee Kryvenko <[email protected]>
@dee-kryvenko dee-kryvenko requested a review from a team as a code owner December 19, 2024 22:03
Copy link

bunnyshell bot commented Dec 19, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@dee-kryvenko dee-kryvenko changed the title Tidy up Grafana dashboard chore: Tidy up Grafana dashboard Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (8841b0d) to head (6640b9b).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21265      +/-   ##
==========================================
- Coverage   55.15%   53.24%   -1.92%     
==========================================
  Files         337      337              
  Lines       57056    57056              
==========================================
- Hits        31472    30379    -1093     
- Misses      22879    24028    +1149     
+ Partials     2705     2649      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for final review
Development

Successfully merging this pull request may close these issues.

2 participants