Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use github.com/golang-jwt/jwt/v5 #21276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

gomodguard allows to block some dependencies.

This ensure that github.com/golang-jwt/jwt/v5 is used instead of github.com/golang-jwt/jwt/v4

Copy link

bunnyshell bot commented Dec 20, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mmorel-35 mmorel-35 force-pushed the gomodguard/jwt branch 6 times, most recently from 8487f7a to 17ceb61 Compare December 20, 2024 13:26
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.32%. Comparing base (8126508) to head (45f03c4).

Files with missing lines Patch % Lines
pkg/apiclient/apiclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21276      +/-   ##
==========================================
- Coverage   55.19%   53.32%   -1.88%     
==========================================
  Files         337      337              
  Lines       57058    57057       -1     
==========================================
- Hits        31496    30427    -1069     
- Misses      22863    23979    +1116     
+ Partials     2699     2651      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as ready for review December 20, 2024 14:14
@mmorel-35 mmorel-35 requested a review from a team as a code owner December 20, 2024 14:14
@mmorel-35 mmorel-35 force-pushed the gomodguard/jwt branch 2 times, most recently from 9922807 to 834dcce Compare December 20, 2024 21:49
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmorel-35 mmorel-35 force-pushed the gomodguard/jwt branch 2 times, most recently from 0ae042a to f966b7a Compare December 22, 2024 02:01
@mmorel-35 mmorel-35 force-pushed the gomodguard/jwt branch 2 times, most recently from 3f3837d to 124a76d Compare December 29, 2024 15:28
@pasha-codefresh
Copy link
Member

@mmorel-35 did you check any breaking chages with it? did you check if v4 is compatible with v5?

@mmorel-35
Copy link
Contributor Author

What do you mean?
I updated the code to handle the changes I saw

@mmorel-35 mmorel-35 force-pushed the gomodguard/jwt branch 2 times, most recently from a610561 to 0f3d8bd Compare December 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for final review
Development

Successfully merging this pull request may close these issues.

4 participants