Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse common PermissionDeniedAPIError #21283

Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 21, 2024

Description

Reuse common.PermissionDeniedAPIError instead of redefining it

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 21, 2024 10:06
Copy link

bunnyshell bot commented Dec 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (635e592) to head (1c08ffb).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
server/repository/repository.go 66.66% 2 Missing ⚠️
server/application/application.go 80.00% 1 Missing ⚠️
server/application/websocket.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21283   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         337      337           
  Lines       57058    57058           
=======================================
  Hits        31487    31487           
  Misses      22875    22875           
  Partials     2696     2696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the error-is/permission-denied branch 2 times, most recently from c046155 to 0a1f002 Compare December 26, 2024 20:33
@mmorel-35 mmorel-35 force-pushed the error-is/permission-denied branch from 0a1f002 to 214271b Compare December 28, 2024 13:01
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you fix the failing e2e tests?

@mmorel-35 mmorel-35 force-pushed the error-is/permission-denied branch from 214271b to 344bc38 Compare December 29, 2024 21:12
@mmorel-35 mmorel-35 requested a review from reggie-k December 29, 2024 21:54
@mmorel-35
Copy link
Contributor Author

I don't see what was causing the issues, I don't see them after rebase

@mmorel-35 mmorel-35 force-pushed the error-is/permission-denied branch from 344bc38 to 1c08ffb Compare December 31, 2024 06:41
@pasha-codefresh pasha-codefresh merged commit ffdbcb6 into argoproj:master Dec 31, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the error-is/permission-denied branch December 31, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants