Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable importas for k8s.io/apimachinery/pkg/apis/meta/v1 #21284

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Importas helps ensure consistency of imports aliases.

This is only for k8s.io/apimachinery/pkg/apis/meta/v1 yet here

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 21, 2024 12:00
Copy link

bunnyshell bot commented Dec 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 44.73684% with 42 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (635e592) to head (6766a3b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/backup.go 0.00% 17 Missing ⚠️
applicationset/utils/selector.go 20.00% 4 Missing ⚠️
cmd/argocd/commands/admin/cluster.go 0.00% 4 Missing ⚠️
cmd/argocd/commands/admin/repo.go 0.00% 3 Missing ⚠️
cmd/argocd/commands/admin/settings.go 50.00% 2 Missing ⚠️
controller/sync.go 60.00% 2 Missing ⚠️
notification_controller/controller/controller.go 60.00% 1 Missing and 1 partial ⚠️
server/cluster/cluster.go 50.00% 2 Missing ⚠️
cmd/argocd/commands/admin/app.go 75.00% 1 Missing ⚠️
cmd/argocd/commands/admin/initial_password.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21284      +/-   ##
==========================================
+ Coverage   55.18%   55.20%   +0.02%     
==========================================
  Files         337      337              
  Lines       57058    57058              
==========================================
+ Hits        31487    31500      +13     
+ Misses      22875    22856      -19     
- Partials     2696     2702       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the importas-metav1 branch 2 times, most recently from 3979787 to 0ac0b98 Compare December 28, 2024 13:01
@pasha-codefresh pasha-codefresh merged commit 8126508 into argoproj:master Dec 31, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the importas-metav1 branch December 31, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants