fix: Change applicationset generate HTTP method to avoid route conflicts (cherry-pick #20758) #21300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…cts (#20758) * Change applicationset generate HTTP method to avoid route conflicts Signed-off-by: Amit Oren <[email protected]> * Update server/applicationset/applicationset.proto Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Amit Oren <[email protected]> * Codegen Signed-off-by: Amit Oren <[email protected]> --------- Signed-off-by: Amit Oren <[email protected]> Signed-off-by: Amit Oren <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
agaudreault
approved these changes
Dec 23, 2024
|
hey @agaudreault anything to do with these failures? It doesn't seem to be related to the changes, perhaps a rerun? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #21300 +/- ##
================================================
+ Coverage 55.00% 55.06% +0.06%
================================================
Files 320 320
Lines 54830 54830
================================================
+ Hits 30157 30193 +36
+ Misses 22082 22044 -38
- Partials 2591 2593 +2 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Change applicationset generate HTTP method to avoid route conflicts (#20758)
Signed-off-by: Amit Oren [email protected]
Co-authored-by: Alexandre Gaudreault [email protected]
Signed-off-by: Amit Oren [email protected]
Signed-off-by: Amit Oren [email protected]
Signed-off-by: Amit Oren [email protected]
Signed-off-by: Amit Oren [email protected]
Co-authored-by: Alexandre Gaudreault [email protected]