You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function divide_by_vanishing_poly(domain) for the DensePolynomial, seems assuming the domain is a multiplicative subgroup, i.e., the vanishing polynomial is of the form x^n - 1. However, this fact is not reflecting from the comments and description of such function. In practice, the domain could also be a coset(i.e.,an "offset" domain, where the vanishing polynomial of the form x^n - w for a specific w). Perhaps this function needs to be refined a little bit for more clarification, or adapt to a more general domain.
The text was updated successfully, but these errors were encountered:
haogaobill
changed the title
Potential Bug: The DensePolynomial::divide_by_vanishing_poly seems only consider the case of multiplicative subgroup
Potential refine: The DensePolynomial::divide_by_vanishing_poly seems only consider the case of multiplicative subgroup
Dec 12, 2024
The function divide_by_vanishing_poly(domain) for the DensePolynomial, seems assuming the domain is a multiplicative subgroup, i.e., the vanishing polynomial is of the form x^n - 1. However, this fact is not reflecting from the comments and description of such function. In practice, the domain could also be a coset(i.e.,an "offset" domain, where the vanishing polynomial of the form x^n - w for a specific w). Perhaps this function needs to be refined a little bit for more clarification, or adapt to a more general domain.
The text was updated successfully, but these errors were encountered: