Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential refine: The DensePolynomial::divide_by_vanishing_poly seems only consider the case of multiplicative subgroup #902

Open
haogaobill opened this issue Dec 11, 2024 · 0 comments

Comments

@haogaobill
Copy link

The function divide_by_vanishing_poly(domain) for the DensePolynomial, seems assuming the domain is a multiplicative subgroup, i.e., the vanishing polynomial is of the form x^n - 1. However, this fact is not reflecting from the comments and description of such function. In practice, the domain could also be a coset(i.e.,an "offset" domain, where the vanishing polynomial of the form x^n - w for a specific w). Perhaps this function needs to be refined a little bit for more clarification, or adapt to a more general domain.

@haogaobill haogaobill changed the title Potential Bug: The DensePolynomial::divide_by_vanishing_poly seems only consider the case of multiplicative subgroup Potential refine: The DensePolynomial::divide_by_vanishing_poly seems only consider the case of multiplicative subgroup Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant