Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow specifying ingressClassName from values.yaml #126

Open
tpoxa opened this issue Nov 6, 2023 · 1 comment
Open

Feature: Allow specifying ingressClassName from values.yaml #126

tpoxa opened this issue Nov 6, 2023 · 1 comment

Comments

@tpoxa
Copy link

tpoxa commented Nov 6, 2023 •
edited
Loading

Also, would be awesome to make ingress optional, like ingress.enabled: true
@arttor
Copy link
Owner

arttor commented Nov 7, 2023

Good idea! Probably the best way is to modify the ingress processor pkg/processor/service/ingress.go in the following way:

  1. Wrap template with {{- if ...
  2. Add ingress.enabled to values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpoxa @arttor