-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we need checker rules? #280
Comments
I would definitely put that on the scope for the next OpenMATERIAL 3D project. |
We discussed this again and it might make sense to define a couple of basic rules already, so we can set up the documentation and everything we need. This will make it easier to extend the set of rules in the future. |
Rules have an ID in the following format: The emanating-entity is asam.net.
Another possibility would be to use the rule-set string as a differentiation between general, geometry and material. On the other had, we might want to use it to group rules within the sub-parts. |
Proposed rulesGeneralasam.net:xom:1.0.0:general.valid-json-document: ASAM OpenMATERIAL 3D files with the file extensions .xoma, .xomm, .xomp or .xompt shall be valid json documents. asam.net:xom:1.0.0:general.valid-schema: ASAM OpenMATERIAL 3D files with the file extensions .xoma, .xomm, .xomp or .xompt shall be valid according to their corresponding json schema. asam.net:xom:1.0.0:general.uris_exist: If an URI property to other file is set in a json file, the file linked in that property shall exist. Geometryasam.net:xom-geo:1.0.0:asset.vehicleClassData-defined: If an asset is of type 'vehicle', the property 'vehicleClassData' must be set in the metadata. asam.net:xom-geo:1.0.0:asset.humanClassData-defined: If an asset is of type 'human', the property 'humanClassData' must be set in the metadata. I propose to leave out any rules related to the inside of 3D model files for now, because checking them in the checker bundle would require loading these files. Because of the multiple supported file formats (glTF, FBX, USD) this is a bit more implementation work. It would make sense to give this kind of implementation to a suitable service provider in the next OpenMATERIAL 3D project. |
I think we have not defined this in the documentation, yet. But should all meshes either have an OpenMATERIAL assignment texture or be covered in the mapping table by name? In other words: do we require an asset to be fully defined by OpenMATERIAl materials? Or can there be meshes without an OpenMATERIAL assigned to it? In any case, this rule most likely requires to load the 3D model, so I would not implement it in this project, but we can already specify it in the documentation at least. |
Decision about rule IDs:
|
Describe the problem/question
Do we need checker rules that can be implemented later to be used i.e in the Quality Checker Framework?
(see in OpenDRIVE (https://publications.pages.asam.net/standards/ASAM_OpenDRIVE/ASAM_OpenDRIVE_Specification/latest/specification/16_annexes/map_rules.html) and OpenSCENARIO XML)
Describe your research
The ASAM Quality Checker Framework (https://github.com/asam-ev/qc-framework) operates through a series of specialized "checkers," organized into checker libraries. These checkers evaluate different aspects of your files, ensuring they meet the required quality standards.
The text was updated successfully, but these errors were encountered: