Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing <body> node in layout xml using form generate command #522

Open
azmeehan opened this issue Aug 17, 2020 · 8 comments
Open

Missing <body> node in layout xml using form generate command #522

azmeehan opened this issue Aug 17, 2020 · 8 comments

Comments

@azmeehan
Copy link

The generated layout XML files under Adminhtml/layout when running magento2:generate:ui:form command are missing nodes.
@astorm
Copy link
Owner

astorm commented Aug 18, 2020

@azmeehan Nice to meet you -- can you please provide the exact command invocation that's causing you the problem?

@azmeehan
Copy link
Author

Likewise @astorm, great to meet you also. The command Ive been running is: pestle magento2:generate:ui:form then following the CLI prompts.

@astorm
Copy link
Owner

astorm commented Aug 19, 2020

@azmeehan What values do you enter into the prompts that reproduces the behavior?

@azmeehan
Copy link
Author

azmeehan commented Aug 19, 2020 •
edited
Loading

@astorm,
Which Module? (Pulsestorm_Formexample)] Azmeehan_Cin7update
Model Class? (Pulsestorm\Formexample\Model\Thing)] Azmeehan\Cin7update\Model\Config
ACL Rule for Controllers? (Pulsestorm_Formexample::ruleName)] Azmeehan_Cin7update::cin7

@astorm
Copy link
Owner

astorm commented Aug 19, 2020

Thank you @azmeehan -- I ran a quick test with your module names/examples and everything seemed to be working correctly.

What problem is the missing <body/> tag causing you? Does it not work in a particular version of Magento? (what version?) Or does is cause some other problem?

@azmeehan
Copy link
Author

azmeehan commented Aug 21, 2020 •
edited
Loading

So the layout files you generated had <body> nodes? Its not a showstopper, Schema validation fails in IDE (phpStorm) without <body> nodes.

Im using bin/magento dev:urn-catalog:generate .idea/misc.xml to generate mappings in the IDE, possibly something up there thats causing this.

@astorm
Copy link
Owner

astorm commented Aug 22, 2020

Ah, I understand now. You opened this bug because an IDE reported a schema error. Let us know what you find out. As far we know the generated file does conform to the schema that's linked in itself -- if it didn't M2 would reject the file. M2 has two forms of layout update XML files -- one has a body tag, and the other doesn't. If you find information that indicates the later is no longer supported or in use let us know what the right structure and schema for this file is and we'll see what we can do about changing it.

Thanks for caring enough to open an issue, even if we ended up not taking action it's still nice to see :)

We're going to close this out for now, but feel free to open a new issue or keep this conversation going if we need to reopen.

@azmeehan
Copy link
Author

@astorm thanks man, Ill put more detail in issues in future. Thanks for putting together pestle and your M2 docs as well, really helps mere mortals like myself understand Magento better ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astorm @azmeehan