Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] remove TODO catch-all case in infer_binary_expression #14549

Open
carljm opened this issue Nov 22, 2024 · 0 comments · May be fixed by #15161
Open

[red-knot] remove TODO catch-all case in infer_binary_expression #14549

carljm opened this issue Nov 22, 2024 · 0 comments · May be fixed by #15161
Assignees
@dcreager
Labels
red-knot Multi-file analysis & type inference

Comments

@carljm
Copy link
Contributor

carljm commented Nov 22, 2024 •
edited
Loading

Similar to #14548, just a slightly bigger task, since binary expressions naturally have a larger possibility matrix (though again, many combinations should simply result in falling back to Type::Instance handling.)
@carljm carljm added the red-knot Multi-file analysis & type inference label Nov 22, 2024
@carljm carljm self-assigned this Nov 22, 2024
@dcreager dcreager assigned dcreager and unassigned carljm Dec 19, 2024
@dcreager dcreager linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcreager dcreager

Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't special-case class instances in binary expression inference astral-sh/ruff
2 participants
@dcreager @carljm