-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: removed AsyncAPI CLI command bash and replace with CLI docs link #1371
base: master
Are you sure you want to change the base?
Conversation
|
WalkthroughThe documentation for the AsyncAPI generator has been reorganized to present a clearer, more structured usage guide. The "AsyncAPI CLI" section now features detailed subsections covering global templates (installed via Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/generator/docs/usage.md (2)
7-13
: Refined Navigation List for Usage DocumentationThe bullet list under "There are two ways to use the generator:" has been restructured to clearly enumerate the different usage approaches. This update improves navigation and makes it easier for users to jump to the specific sections they need.
Please verify that the anchor links (for example, the one in "Using as a module/package") correctly resolve in your documentation rendering environment. If necessary, consider making the anchor IDs more consistent (e.g., using hyphenation) to avoid any potential linking issues.
15-19
: Directing Users to Official CLI DocumentationThe "AsyncAPI CLI" section now clearly indicates that complete command usage and options are available in the official AsyncAPI CLI documentation. This fulfills the PR objective to remove the direct Bash command details in favor of a streamlined reference, thereby reducing maintenance overhead and ensuring users always have access to up-to-date information.
As a follow-up, please consider whether the inline header "
asyncapi generate fromTemplate ASYNCAPI TEMPLATE
" should remain as a reference or if it might be redundant given that users are being redirected to the comprehensive CLI docs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/generator/docs/usage.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Test generator as dependency with Node 20
- GitHub Check: Test generator as dependency with Node 18
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
Description
We need to manually change the usage of command
asyncapi generate fromTemplate ASYNCAPI TEMPLATE
in generator docs according to CLI. So we can replace the usage bash with direct link to commandasyncapi generate fromTemplate ASYNCAPI TEMPLATE
.Related issue(s)
Fixes: #1366
Summary by CodeRabbit