Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-clock-csv--escape should be "public" #21

Open
sshaw opened this issue Jun 1, 2019 · 5 comments
Open

org-clock-csv--escape should be "public" #21

sshaw opened this issue Jun 1, 2019 · 5 comments

Comments

@sshaw
Copy link

sshaw commented Jun 1, 2019

Since this can be called in a user-defined format function is should use the "public" convention, e.g. one less "-": org-clock-csv-escape.

If backwards compatibility is a concern you can do something like:

(defun org-clock-csv--escape (str)
  (warn "org-clock-csv--escape is deprecated and will be removed in version X. Use org-clock-csv-escape instead") 
  (org-clock-csv-escape str))
@sshaw
Copy link
Author

sshaw commented Jun 1, 2019

Actually, I think emacs has some properties that it uses for deprecation... 🤔

@atheriel
Copy link
Owner

atheriel commented Jun 3, 2019

Can you clarify what user-defined functions would need to call it?

@sshaw
Copy link
Author

sshaw commented Jun 3, 2019

Can you clarify what user-defined functions would need to call it?

Anything one sets org-clock-csv-row-fmt to.

@ghost
Copy link

ghost commented Apr 22, 2020

@atheriel how to customize org-clock-csv-row-fmt without access to org-clock-csv--escape ? Can you please give an example of custom row format ?

@riceissa
Copy link

I ran into this same issue today. I ended up just forking the project and modifying org-clock-csv-default-row-fmt in place just to be able to use org-clock-csv--escape (riceissa@6383544), which doesn't seem ideal. What I would like instead is to be able to just define a custom org-clock-csv-row-fmt in my init.el or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants