Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceessUrl not used on certain cards #51

Open
s0up4200 opened this issue Nov 17, 2024 · 0 comments
Open

acceessUrl not used on certain cards #51

s0up4200 opened this issue Nov 17, 2024 · 0 comments
Labels
bug Something isn't working web

Comments

@s0up4200
Copy link
Collaborator

Describe the bug

accessUrl is not used on certain links in the UI. It should always use service.accessUrl if it exists.

Maintainerr:

<a
href={`${service?.url}/collections`}
target="_blank"
rel="noopener noreferrer"
className="font-medium text-white hover:text-blue-400 flex items-center group"
>

Autobrr:

const baseUrl = service?.url || "";
// Function to construct the full URL for releases
const getReleasesUrl = (actionStatus?: string) => {
const url = new URL("releases", baseUrl);
if (actionStatus) {
url.searchParams.set("action_status", actionStatus);
}
return url.toString();
};

Overseerr:

<a
href={request.media.serviceUrl}
target="_blank"
rel="noopener noreferrer"
className="text-xs font-medium text-gray-200 truncate hover:text-blue-400 transition-colors flex items-center"
title="View Details"
>
{getMediaTitle(request)}
<ArrowTopRightOnSquareIcon className="h-3.5 w-3.5 ml-1 text-blue-400" />
</a>

Additional context
Example of how its done in Radarr/Sonarr queue:

// Use accessUrl if available, otherwise fall back to url
const openUrl = service.accessUrl || service.url;

@s0up4200 s0up4200 added bug Something isn't working web labels Nov 17, 2024
@s0up4200 s0up4200 changed the title [BUG] acceessUrl not used on certain cards acceessUrl not used on certain cards Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web
Projects
None yet
Development

No branches or pull requests

1 participant