-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bug in ablation #203
Comments
Hi @Michael190502 , thanks for reporting this issue, we will have a look at it! |
Hi @Michael190502 , I am currently looking into the issue, could you provide a minimal code example/snippet so I can recreate the problem? |
Hi @KrissiHub, as I dont have a prepared run at hand I utilized the example for ablation from examples/api/ablation_paths.py to create an example showing the difference. To demonstrate the difference I made the following simple changes:
I hope this suffices as an example even if it is not a code snippet. Afterwards you could replace all encode_config with get_array to see the difference in the computed ablation paths. I included the two improvement plots before and after changing the encoding. (The first one is after) |
Hi,
I think I found a possible bug in the ablation file.
Firstly I think after the following line
DeepCAVE/deepcave/evaluators/ablation.py
Line 128 in 58d6801
Secondly the ablation path analysis did not work correctly for me when I had only categorical hyperparameters. I traced the problem to the ablation file where "encode_config" is used instead of "get_array". This resulted, in my case at least, in an encoding normalised to [0,1] instead of the number of the choice of the categorical hyperparameter. This resulted in the predicted performance of the default configuration being equal to the predicted performance of the incumbent.
It worked correctly when I replaced "encode_config" with "get_array".
Please let me know if this is something specific to my setup or if I did something wrong. I will append an image comparing the encoding of "get_array" to "encode_config" for clarity.
The text was updated successfully, but these errors were encountered: