Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Embedding Encoder? #8

Open
tomviering opened this issue Jun 30, 2024 · 0 comments
Open

Bug in Embedding Encoder? #8

tomviering opened this issue Jun 30, 2024 · 0 comments

Comments

@tomviering
Copy link

I think there is a bug in the Embedding Encoder, see here:

return (x - self.min_max[0] // split_size).int().clamp(0, self.num_embs - 1)

Currently its stated that
(x - self.min_max[0] // split_size).int().clamp(0, self.num_embs - 1)
but I believe it should be
((x - self.min_max[0]) // split_size).int().clamp(0, self.num_embs - 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant