Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octoprint-Webclient twitches at layer-change #8

Open
Mercur13 opened this issue Dec 11, 2024 · 3 comments
Open

Octoprint-Webclient twitches at layer-change #8

Mercur13 opened this issue Dec 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Mercur13
Copy link

The display in Octoprint-Webclient (everything below the print-pause-cancel line) twitches every time you change layers because the skipto line is deleted and re-inserted. This is very annoying with small but tall objects.

@awe-source awe-source added the bug Something isn't working label Dec 11, 2024
@awe-source
Copy link
Owner

Thoughts on ditching this feature in favour of allowing users to use other plugins like "display" or do you think this is important specifo to this plugin?

Other wise, we'll need to improve how this is update/rendered to fix this

@Mercur13
Copy link
Author

The frame of your plugin is briefly deleted when layer changes (the display area below is pushed up). Then your frame is 1 or 2 lines tall. (The display area below is pushed down by 1-2 lines). This causes the displayed area below "your" frame to fidgeting.
Why don't you use a fixed size for the frame?

@awe-source
Copy link
Owner

a) because fixed size is bad in general as it wont flow well on small screens etc... (not a deal breaker)
b) I ask because there are several plugins for "show me layer and z height" and I wonder if "do one thing well" is a better motto for this plugin - so removing this saves us from trying to figure it out...
c) it uses the ocotprint api correctly, so the updates all (we think) come from the framework, so we dont think WE are deleting and recreating it... perhaps its as the layer height grows the flickering happens becuase the 'box' is blown out to two lines...

see 0.1.6 to see if this fixes it (made shorter text)... however bigger machines might still suffer when z and layer count gets higher...
if you know more about the dev side let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants