[Question] sm-docker zips and uploads the current dir, not the target dir?

[athewsey]

From my investigations into #2, I saw that sm-docker is zipping and uploading the current folder, not the target folder, when a target is given. E.g:

sm-docker build ./docker
# Uploads all of ./ (not just ./docker) to S3

Is this expected and deliberate for some reason? If you have lots of other stuff in your folder it can make for a significantly slower wait than the (also working) cd ./docker && sm-docker build .

[w601sxs]

also if the current dir does not have a dockerfile, it will still spin off the codebuild job and fail during the build stage. Suggest checking for a dockerfile first before starting the process

[jaipreet-s]

Is this expected and deliberate for some reason?

Hi @athewsey, yes this is expected. See

sagemaker-studio-image-build-cli/sagemaker_studio_image_build/builder.py

Lines 34 to 40 in fb616c0

	with tempfile.TemporaryFile() as tmp:
	with zipfile.ZipFile(tmp, "w") as zip:
	# Zip all files in "dir"
	for dirname, _, filelist in os.walk("."):
	for file in filelist:
	zip.write(f"{dirname}/{file}")
	# Add buildspec.yml

and this is also explained in the README https://github.com/aws-samples/sagemaker-studio-image-build-cli/blame/master/README.md#L31.

However, your point is valid, as the docker CLI honors the target directory and not the current directory. For e.g., docker build examples/basic_build works without having to "cd" into the directory.

[jaipreet-s]

@w601sxs - Good call, that's a great enhancement.