Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-codebuild: missing CodeBuild image types for newly supported environment types #32978

Open
2 tasks
awszhen opened this issue Jan 17, 2025 · 1 comment · May be fixed by #32979
Open
2 tasks

aws-codebuild: missing CodeBuild image types for newly supported environment types #32978

awszhen opened this issue Jan 17, 2025 · 1 comment · May be fixed by #32979
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@awszhen
Copy link
Contributor

awszhen commented Jan 17, 2025

Describe the feature

The CodeBuild CDK code needs to add new image types to match newly supported environment types: LINUX_EC2, ARM_EC2 and WINDOWS_EC2.

Use Case

Users can not create project with fleet configured with LINUX_EC2, ARM_EC2 or WINDOWS_EC2 environment type using CDK.

Proposed Solution

Add new image types LINUX_EC2, ARM_EC2 and WINDOWS_EC2 into file.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Any

Environment details (OS name and version, etc.)

Any
@awszhen awszhen added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 17, 2025
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Jan 17, 2025
@awszhen awszhen linked a pull request Jan 17, 2025 that will close this issue
Open
1 task
@ashishdhingra ashishdhingra self-assigned this Jan 17, 2025
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed @aws-cdk/aws-codebuild Related to AWS CodeBuild needs-triage This issue or PR still needs to be triaged. labels Jan 17, 2025
@ashishdhingra
Copy link
Contributor

  • Per CodeBuild service API CreateProject:environment > ProjectEnvironment, type could have the following valid values: 
    WINDOWS_CONTAINER | LINUX_CONTAINER | LINUX_GPU_CONTAINER | ARM_CONTAINER | WINDOWS_SERVER_2019_CONTAINER | LINUX_LAMBDA_CONTAINER | ARM_LAMBDA_CONTAINER | LINUX_EC2 | ARM_EC2 | WINDOWS_EC2 | MAC_ARM
  • Per AWS::CodeBuild::Project Environment, Type could have following allowed values: 
    WINDOWS_CONTAINER | LINUX_CONTAINER | LINUX_GPU_CONTAINER | ARM_CONTAINER | WINDOWS_SERVER_2019_CONTAINER | LINUX_LAMBDA_CONTAINER | ARM_LAMBDA_CONTAINER | LINUX_EC2 | ARM_EC2 | WINDOWS_EC2 | MAC_ARM

So, LINUX_EC2, ARM_EC2 or WINDOWS_EC2 should be supported for CodeBuild Project.

@ashishdhingra ashishdhingra added @aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 21, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): add new image types awszhen/aws-cdk
2 participants
@awszhen @ashishdhingra