Make Group name configurable within ResourceGroup

[amirahav]

Feature Description

Problem Statement:

The Group name of the CRD created by a ResourceGroup is currently hardcoded. It would be beneficial to be able to define the group name to assist in differentiating kro specific CRDs and user/customer defined CRDs.

Proposed Solution:

Add a group attribute within spec.schema which should default to kro.run, similar to this:

apiVersion: kro.run/v1alpha1
kind: ResourceGroup
metadata:
  name: sqs-queue
spec:
  schema:
    apiVersion: v1alpha1
    kind: Queue
    group: somegroup.xyz.com
    spec:
      ...

Alternatives Considered:

Additional Context:

• Please vote on this issue by adding a 👍 reaction to the original issue
• If you are interested in working on this feature, please leave a comment

[RinkiyaKeDad]

I'm happy to pick this up!

[RinkiyaKeDad]

Here's how I was thinking this could be implemented:

1. Adding Group string to the schema in kro/api/v1alpha1/resource_group.go
2. Passing this information to the buildInstanceResource function in kro/internal/graph /builder.go
3. Further passing this info to SynthesizeCRD in kro/internal/graph /builder.go to get the new CRD which would have the group info.
4. Updating the extractCRDName function to accomodate the newly added Group field during deletion.
5. Updating the GetResourceGroupInstanceGVK and GetResourceGroupInstanceGVR functions in kro/internal/metadata/groupversion.go

Things I'm not sure about:

1. Do we need to do something about internal/metadata/labels.go?

@a-hilaly can you please verify if I'm in the right direction before I start working on this?

Thanks!

[a-hilaly]

@RinkiyaKeDad Thank you for picking this one up!

The steps you described are correct and exactly what we need to do for this feature :) I'm not sure if we need to add any special labels for now. We can always do that in the future.

[a-hilaly]

Thinking out loud maybe we could keep using "apiVersion" to stay consistent with Kubernetes since most users are familiar with that convention?