-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action never completes with Cordova app running on Android #61
Comments
@blefebvre Looks like this is related to #14. Due to a bug, looks like the code is trying to get |
AndroidTracingProbe looks for adb logs that are triggered only for Chrome-Android. All other Chrome WebView apps, including Cordova apps cannot use that. In AndroidTracingProbe, the capabilities were picked up from the browser session rather than than what was passed in. As a result, the lines (that were deleted in this commit) simply passed, causing this to be called even for Cordova apps. As a result, the logs never show up, waitForLogCat timeout and browser-perf failed. The check in this commit basically says that ALL Chrome-Android browser have an activity, and that should be the only time when AndroidTracingProbe should be triggered. See #61
@blefebvre Btw, nice talk at PGDay EU. Sorry, I could not fix this in time for PGday. |
You don't even need to wait for taps and clicks, you could technically navigate to the slow page (or the fast page) and run the tests. |
I ran the tests now and they run. Closing the issue now. |
Verified that version |
Includes a fix for axemclion/browser-perf#61
When running a browser-perf test via the Node API targeting Android hardware, my test action never appears to be fired and the action eventually times out.
Environment:
browser-perf 1.4.5
chromedriver 2.21.371459
adb 1.0.32
PhoneGap CLI 6.2.1
Nexus 5 running Android 5.0.1
To reproduce:
phonegap run android --device
./chromedriver --verbose
node tests/android/1-slow-scroll.js
Result:
[ undefined ]
).The text was updated successfully, but these errors were encountered: