Fix codebase to build with Qt 5

[jakepetroules]

The only remaining issue is HSSObject::shared_from_this() / HSSParserNode::shared_from_this(); that QWeakPointer constructor overload is no longer available.

Also, even Google discourages use of shared pointers. https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Smart_Pointers

[veosotano]

Is the .toStrongRef() method still there or will we need to get rid of smart pointers entirely?

Sent from my iPhone

On 04/04/2013, at 02:56, Jake Petroules [email protected] wrote:

The biggest issue is HSSObject::shared_from_this(); that QWeakPointer constructor overload is no longer available.

Also, even Google discourages use of shared pointers. https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Smart_Pointers

—
Reply to this email directly or view it on GitHub.

[jakepetroules]

Of course not. The constructor in question was simply removed because it allowed the classes to be used in an incorrect manner. I'm not really sure but you can be certain it was for a good reason.

We should still lessen our usage of smart pointers though.