Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Sapphiron's Chamber in Naxxramas until all wings are cleared #308

Open
Gultask opened this issue Feb 15, 2023 · 4 comments
Open

Lock Sapphiron's Chamber in Naxxramas until all wings are cleared #308

Gultask opened this issue Feb 15, 2023 · 4 comments

Comments

@Gultask
Copy link
Contributor

Gultask commented Feb 15, 2023

This was a requirement up until Patch 3.3.0

Could this maybe be done through conditions?

azerothcore/azerothcore-wotlk#15048

@55Honey
Copy link
Member

55Honey commented Feb 15, 2023

I don't see BOSS_STATE as a condition and i also don't see area triggers in types. Maybe CONDITION_SOURCE_TYPE_SPELL could work ad type, but there's still no condition i can think off.

@Nyeriah
Copy link
Member

Nyeriah commented Feb 15, 2023

It can't, you'll need to replicate the instance file as done with UBRS/MC, not something you should be bothering with until you actually need because quite frankly maintaining those duplicated files is a pain in the ass and the file itself is in a bad shape currently and will likely suffer many changes from now to 1-2 years when CC will actually need it.

@55Honey
Copy link
Member

55Honey commented Feb 15, 2023

I'm thinking of a conf option to be honest, in the core.

@Nyeriah
Copy link
Member

Nyeriah commented Feb 15, 2023

I’ll disagree with this as then you fundamentally have no reason not to implement every other progression change straight into the core and that’s not something we wish for, it’s the reason why this module was created in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants