Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overlayDestroy to modals #16

Closed
soumak77 opened this issue Jul 17, 2016 · 1 comment
Closed

Add overlayDestroy to modals #16

soumak77 opened this issue Jul 17, 2016 · 1 comment
Labels
enhancement
Milestone
2.0 Release

Comments

@soumak77
Copy link
Contributor

soumak77 commented Jul 17, 2016 •
edited
Loading

Sparked by this issue, it would be useful to have an overlayDestroy property for modals. This new property would act similar to overlayClose, except that it would also destroy the modal after closing it. This way the modal is completely removed from the DOM when the overlay is clicked. As shown in the issue above, there is a memory leak if you attempt to use overlayClose without providing an ID. Using overlayDestroy in that case would solve the issue.
@soumak77 soumak77 added this to the 1.3 Release milestone Aug 10, 2016
soumak77 added a commit that referenced this issue Aug 11, 2016
@soumak77
add destroy-on-close support for modals
cb3c5f2 
#16
@soumak77
Copy link
Contributor Author

I added a destroy-on-close attribute so that the functionality can be used without an overlay.

@soumak77 soumak77 mentioned this issue Aug 11, 2016
Open
@soumak77 soumak77 mentioned this issue Aug 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0 Release
Development

No branches or pull requests
1 participant
@soumak77