string split/rsplit do not accept named parameters

[nanaze]

Python strings accept named parameters for the string.strip/rstrip functions

$ python3
>>> "a-b-c-d".split("-", maxsplit=2)
['a', 'b', 'c-d']
>>> "a-b-c-d".rsplit("-", maxsplit=2)
['a-b', 'c', 'd']
>>> 

I was surprised that this failed when used in a .bzl file

adding the following to src/test/java/net/starlark/java/eval/testdata/string_split.star will cause the test to fail

assert_eq("a-b-c-d".split("-", maxsplit=2), ["a", "b", "c-d"])
assert_eq("a-b-c-d".rsplit("-", maxsplit=2),  ["a-b", "c", "d"]);

error:

Error in split: split() got named argument for positional-only parameter 'maxsplit'

Marking these methods as "named" in src/main/java/net/starlark/java/eval/StringModule.java fixes the problem.

I have a Google-internal demonstration change at go/kvlhy

[brandjon]

Looks like we don't say in the spec whether maxsplit is a named param. Filed bazelbuild/starlark#210.

[github-actions]

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

[github-actions]

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!