Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable_mtime for py3_image #2269

Open
amir-f opened this issue Aug 19, 2023 · 1 comment
Open

portable_mtime for py3_image #2269

amir-f opened this issue Aug 19, 2023 · 1 comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not

Comments

@amir-f
Copy link

amir-f commented Aug 19, 2023

🚀 feature request

Description

When using py3_image the mtime (modification time) for all the files are set to 0 unix time (cira 1970). Some python libraries panic when they see that (eg. zipfile python builtin lib ValueError: ZIP does not support timestamps before 1980)

Describe the solution you'd like

container_image has an option to set all mtimes to a fixed valued: see portable_mtime but IIUC it needs to be routed to py3_image through the signatures somehow, hence this feature request.

Basically can we by default or through an option in py3_image set all the mtimes to something other than 0 ?

Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

No branches or pull requests

1 participant