From 222ec4b98bc5e3a9f0b20f90eb632176f304a8f8 Mon Sep 17 00:00:00 2001 From: Greg Roodt Date: Tue, 20 Dec 2022 08:59:06 +1100 Subject: [PATCH] Remove unused code (#933) --- python/pip_install/extract_wheels/BUILD | 11 ---- python/pip_install/extract_wheels/bazel.py | 57 ------------------- .../extract_wheels/requirements_bzl_test.py | 19 ------- 3 files changed, 87 deletions(-) delete mode 100644 python/pip_install/extract_wheels/requirements_bzl_test.py diff --git a/python/pip_install/extract_wheels/BUILD b/python/pip_install/extract_wheels/BUILD index bc11885026..1420f4be80 100644 --- a/python/pip_install/extract_wheels/BUILD +++ b/python/pip_install/extract_wheels/BUILD @@ -148,17 +148,6 @@ py_test( ], ) -py_test( - name = "requirements_bzl_test", - size = "small", - srcs = [ - "requirements_bzl_test.py", - ], - deps = [ - ":lib", - ], -) - filegroup( name = "distribution", srcs = glob( diff --git a/python/pip_install/extract_wheels/bazel.py b/python/pip_install/extract_wheels/bazel.py index 8f442c930f..28a229277d 100644 --- a/python/pip_install/extract_wheels/bazel.py +++ b/python/pip_install/extract_wheels/bazel.py @@ -201,63 +201,6 @@ def generate_build_file_contents( ) -def generate_requirements_file_contents(repo_name: str, targets: Iterable[str]) -> str: - """Generate a requirements.bzl file for a given pip repository - - The file allows converting the PyPI name to a bazel label. Additionally, it adds a function which can glob all the - installed dependencies. - - Args: - repo_name: the name of the pip repository - targets: a list of Bazel labels pointing to all the generated targets - - Returns: - A complete requirements.bzl file as a string - """ - - sorted_targets = sorted(targets) - requirement_labels = ",".join(sorted_targets) - whl_requirement_labels = ",".join( - '"{}:whl"'.format(target.strip('"')) for target in sorted_targets - ) - return textwrap.dedent( - """\ - all_requirements = [{requirement_labels}] - - all_whl_requirements = [{whl_requirement_labels}] - - def requirement(name): - name_key = name.replace("-", "_").replace(".", "_").lower() - return "{repo}//pypi__" + name_key - - def whl_requirement(name): - return requirement(name) + ":{whl_file_label}" - - def data_requirement(name): - return requirement(name) + ":{data_label}" - - def dist_info_requirement(name): - return requirement(name) + ":{dist_info_label}" - - def entry_point(pkg, script = None): - if not script: - script = pkg - return requirement(pkg) + ":{entry_point_prefix}_" + script - - def install_deps(): - fail("install_deps() only works if you are creating an incremental repo. Did you mean to use pip_parse()?") - """.format( - repo=repo_name, - requirement_labels=requirement_labels, - whl_requirement_labels=whl_requirement_labels, - whl_file_label=WHEEL_FILE_LABEL, - data_label=DATA_LABEL, - dist_info_label=DIST_INFO_LABEL, - entry_point_prefix=WHEEL_ENTRY_POINT_PREFIX, - ) - ) - - def sanitise_name(name: str, prefix: str) -> str: """Sanitises the name to be compatible with Bazel labels. diff --git a/python/pip_install/extract_wheels/requirements_bzl_test.py b/python/pip_install/extract_wheels/requirements_bzl_test.py deleted file mode 100644 index ae28e1fc38..0000000000 --- a/python/pip_install/extract_wheels/requirements_bzl_test.py +++ /dev/null @@ -1,19 +0,0 @@ -import unittest - -from python.pip_install.extract_wheels import bazel - - -class TestGenerateRequirementsFileContents(unittest.TestCase): - def test_all_wheel_requirements(self) -> None: - contents = bazel.generate_requirements_file_contents( - repo_name="test", - targets=['"@test//pypi__pkg1"', '"@test//pypi__pkg2"'], - ) - expected = ( - 'all_whl_requirements = ["@test//pypi__pkg1:whl","@test//pypi__pkg2:whl"]' - ) - self.assertIn(expected, contents) - - -if __name__ == "__main__": - unittest.main()