From 679ba7cae0fec162f1221dcc1d1ef7a79d758651 Mon Sep 17 00:00:00 2001 From: Thomas Ball Date: Thu, 16 Nov 2023 23:27:09 +0000 Subject: [PATCH] fix(toolchains): include tcl/** files in Windows interpreter (#1552) closes #1544 The tcl subdirectory of the interpreter Windows build needs to be kept otherwise packages such as matplotlib will break. Co-authored-by: Richard Levasseur --- CHANGELOG.md | 2 ++ python/repositories.bzl | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5ac2a3f0c3..d6b419d08c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -97,6 +97,8 @@ Breaking changes: * (gazelle) Generate a single `py_test` target when `gazelle:python_generation_mode project` is used. +* (toolchains) Keep tcl subdirectory in Windows build of hermetic interpreter. + * (bzlmod) sub-modules now don't have the `//conditions:default` clause in the hub repos created by `pip.parse`. This should fix confusing error messages in case there is a misconfiguration of toolchains or a bug in `rules_python`. diff --git a/python/repositories.bzl b/python/repositories.bzl index b293b556e9..37cc34e271 100644 --- a/python/repositories.bzl +++ b/python/repositories.bzl @@ -259,6 +259,7 @@ def _python_repository_impl(rctx): "libs/**", "Scripts/**", "share/**", + "tcl/**", ] else: glob_include += [