Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate default cannot be overridden by configuration #1

Open
bbengfort opened this issue Apr 3, 2019 · 0 comments
Open

Aggregate default cannot be overridden by configuration #1

bbengfort opened this issue Apr 3, 2019 · 0 comments

Comments

@bbengfort
Copy link
Owner

On config.go L31 - the default aggregate option is set to true, however, because of the way the config.Update method works on config.go L98 with the IsZero check, this cannot be set to false via an external configuration file. This needs to be rethought both here and in epaxos.

Note that the epaxos solution is to simply set aggregate to false as the default, then specify true as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant