-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colours / symbology of Truck Routes layer (mentioned in #204) #221
Comments
Current symbology concerns discussed. |
@gk-tl and I have come up with a couple of options for revised symbology. It would be great to get your feedback on which one your prefer. Draw Order - Thickness Value
I believe that moving the MRN to this position in the draw order will also move it in the layer list. This is fine. Thickness and relationship to zooming Option 1 Symbols OSOW Routes (order not correct, see above for order): |
@al-tabb I'm looking into these symbolization changes, but I'm bumping into a CORS issue when when trying to run the app in my dev environment. Would it be possible to add 'translink-d.apps.gov.bc.ca:7443' as an allowed origin for https://devapi.regionalroads.com? |
Sure, I've added the requested URL to the allowed origins list. Let me know if you have any more issues. |
@qqnluaq in my experience I've found the symbolization options in Leaflet to be somewhat limited. I'm not aware of a clean, out of the box solution for generating the Truck Route symbols in the images above. I know you can stack multiple layers to get those kinds of line symbols, but I don't know if we could generate those symbols in the legend or layer list. Are you aware of a way to support this symbology on the map and legend? |
@dgboss Yes, generating this styling for the layers is possible by stacking copies of the layer rendered with different styles. |
We're OK with using a static legend if it makes this change easier to implement. |
That's great to hear @al-tabb because it seems that's where we've landed due to the complexity of the proposed changes. We are anticipating hearing more about availability for starting this work. In terms of feedback, consensus here is that option 2 in the attached file looks more polished. |
Due to the colour scheme of the new basemap we're thinking that option 1 is preferred so that the layers will stand out. In response to the comment in the pdf we are open to changing the line thicknesses closer to option 2 to get a cleaner look. The symbology provided (especially the exact thickness of lines) can be adjusted a bit to fit the aesthetic of the map as needed. Let me know if this works on your end. |
@al-tabb A few questions: You also mention that the line thickness should increase as you zoom into the map. Right now there is one step in the line styling at a scale of 1:19000. |
You're right that isn't consistent with the current map. All features with an 'AdvisoryType' = "Restriction" should have the symbology specified for "Truck Travel Restriction or Prohibition". Let's continue to represent this as 'Restrictions' similar to the current legend (i.e. Truck Travel Restriction or Prohibition and Port Restricted Access will collapse into one category). All features with an 'AdvisoryType' = "Truck Travel Warning" should have the symbology specified for "Truck Travel Warning". Let's continue to represent this as 'Advisories' similar to the current legend (i.e. Truck Travel Warning will be relabeled to Advisories. As for the thicknesses I think there will be some trial and error there. I don't have exact widths based on zoom levels in mind. |
@al-tabb Another question: |
Hi Ben - as its own layer, Provincial Highways can stay as is. The layer is meant to be used in conjunction with the MRN layer when a user is primarily interested in showing the extent of the MRN (i.e., all truck route layers are turned off, as shown in the image) |
Related to the above, it would be helpful if the symbology for the truck route layers (collectively the TRN) could be set up such that when the MRN layer is selected, it is easy to see the overlap between the two networks (for example, see which segments of the TRN are not part of the MRN and vice versa). |
@gk-tl @NicoledeGreef A new build with my styling changes in dev: https://translink-d.apps.gov.bc.ca/trp/ |
@qqnluaq Thanks for putting this together. A few comments/questions:
|
These changes are deployed to dev, please verify |
Thanks @qqnluaq @al-tabb here is the Dev URL for your review: |
@al-tabb made updates per your last comment, deployed to dev. |
Changes for review in: https://translink-d.apps.gov.bc.ca/trp/ |
To be discussed at meeting on March 9, 2022. The main part of #204 has reached Production already.
The text was updated successfully, but these errors were encountered: