-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place name searches in the geocoder. #82
Comments
Suggests the following change to the behavior of the route waypoint text box:
Present the results of both requests to the user for selection Why does the geocoder need a front-gate delimiter? |
@qqnluaq - can you please estimate for this proposed item? |
currently SMK uses the If SMK makes 2 requests to the geocoder, would the results have to be merged together (ie duplicates removed, and results somehow sorted in ranking order)? Would the limit of max 5 results still apply? |
@mraross - what's your suggestion? |
currently SMK uses the /addresses endpoint with the geocoder. Is this the right endpoint for this kind of search? Yes. The second request would have the front gate delimiter ("--") tacked on to the addressString if the user didn't enter one already If SMK makes 2 requests to the geocoder, would the results have to be merged together (ie duplicates removed, and results somehow sorted in ranking order)? Merged yes; sorted maybe (you might try just putting named sites after civic addresses); duplicates removed no because the second search for named sites would only be looking for addresses with site names. For example, if the user typed in "Delta", a search for "Delta--" would not return Delta, BC, only Delta Port Entrance and Delta Port Exit. Remember to honour the case where the user has included a front gate delimiter in their input address. Would the limit of max 5 results still apply? No. Increase to at least 8 to allow for up to three site name matches. Feel free to tune to taste. |
@mraross so for the
Is this to be expected? |
Yes because you're hitting geocoder in prod which doesn't have the named sites loaded into it. For various reasons, our dlv and tst geocoders are down. Will let you know when they come back up so you can test. |
You might be able to use score to sort. I suspect site-name matches might score better than civic addresses. If not, we might be able to make it so through our geocoder config app. |
Estimate: |
Try sorting by score; it might just work. |
@gk-tl - this was a late breaking suggestion from @mraross . basically allows for placename searches as well as address searches in the waypoint text boxes without any special action on the part of the end user. can you please review and let me know if this is something you would like us to pursue ahead of March 31? |
In other words, you won't need to enter the frontgate delimeter ("--") that we discussed this morning. |
@al-tabb and I agree this is something that would be helpful to incorporate before March 31, but it also depends on level of effort/work load. The user does have the option to drop the pin//drag and drop etc, so this could equally well wait as an enhancement until after Mar 31 if need be. |
thank you for the notes. given the date let's bundle this post March 31 if that works. |
@mraross created an application ticket: MAP-971
"Currently, to enter a named place like Vanterm as a start or endpoint, you have to type in the first few characters of the name followed by the front-gate delimiter ("--") as in:
Vanterm--
The geocoder will then return a list of the top N best named place matches
Without the front-gate delimiter, the geocoder looks for matches in its list of civic addresses instead.
He proposes a change request in the calls that the map is making in order to handle this scenario.
The text was updated successfully, but these errors were encountered: