Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service names can't be changed #18

Open
wpf500 opened this issue Nov 5, 2024 · 0 comments
Open

Service names can't be changed #18

wpf500 opened this issue Nov 5, 2024 · 0 comments

Comments

@wpf500
Copy link
Member

wpf500 commented Nov 5, 2024

#17 solved most of the stack configuration problems, but there is one more: the service names (app, api_app, etc.) are hardcoded in the router and a few other places.

If we ever wanted to change these names within the main repository, all hosters would have to update their Docker stack configurations. A purer logical separation would be to use environment variables in the router that hosters can specify. In practice, it's far more likely that we add a new service than change the name of an existing one, and that would require a change to the stack configuration in any case, so it's much less problematic than the other problems solved in #17.

Problem: service names are hardcoded in the main repo so can't be changed in this stack configuration
Fix: move service names into environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant