-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'all on one page' snippets #51
Comments
The code, or the screenshot? I think the code is in sync unless if I'm missing something |
The searchvalue argument in replace function. "//g" and "/+/g" return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(//g," ") } return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(/+/g," ") } |
Ah I see that now, thanks. Maybe is a bug with the rakefile at: https://github.com/bgrins/devtools-snippets/blob/master/Rakefile, because gh-pages is up to date after running |
Hm, well running |
And it appears OK in the snippets.json file: https://bgrins.github.io/devtools-snippets/snippets.json |
Well, I'm not sure why but the Line 40 in d401680
with_markup seems to be //g as far as I can tell.
|
The querystrings.js on the github page differs slightly from the source on github, and returns an error when run whereas the source does not.
Might be worth an update!
The text was updated successfully, but these errors were encountered: