Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'all on one page' snippets #51

Open
ljcl opened this issue Sep 8, 2014 · 6 comments
Open

Update 'all on one page' snippets #51

ljcl opened this issue Sep 8, 2014 · 6 comments

Comments

@ljcl
Copy link

ljcl commented Sep 8, 2014

The querystrings.js on the github page differs slightly from the source on github, and returns an error when run whereas the source does not.

Might be worth an update!

@bgrins
Copy link
Owner

bgrins commented Sep 8, 2014

The code, or the screenshot? I think the code is in sync unless if I'm missing something

@hvsw
Copy link
Contributor

hvsw commented Sep 8, 2014

The searchvalue argument in replace function. "//g" and "/+/g"

return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(//g," ") }

return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(/+/g," ") }

@bgrins
Copy link
Owner

bgrins commented Sep 8, 2014

Ah I see that now, thanks. Maybe is a bug with the rakefile at: https://github.com/bgrins/devtools-snippets/blob/master/Rakefile, because gh-pages is up to date after running rake build

@bgrins
Copy link
Owner

bgrins commented Sep 8, 2014

Hm, well running pygmentize -f html snippets/querystringvalues/querystringvalues.js seems to produce the correct output so it's not that

@bgrins
Copy link
Owner

bgrins commented Sep 8, 2014

And it appears OK in the snippets.json file: https://bgrins.github.io/devtools-snippets/snippets.json

@bgrins
Copy link
Owner

bgrins commented Sep 9, 2014

Well, I'm not sure why but the /+/g is still there in the markup variable before the call to with_markup = template.gsub(regex, markup) in the rakefile:

with_markup = template.gsub(regex, markup)
. After this line, with_markup seems to be //g as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants