Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all likelihood and waveform tests to use more recent waveforms #791

Open
bilby-bot opened this issue Feb 23, 2024 · 1 comment · May be fixed by #897
Open

Change all likelihood and waveform tests to use more recent waveforms #791

bilby-bot opened this issue Feb 23, 2024 · 1 comment · May be fixed by #897
Assignees
@GregoryAshton @akjm99

Comments

@bilby-bot
Copy link
Collaborator

In GitLab by @git.ligo:aditya.vijaykumar on Feb 23, 2024, 15:57

Currently, tests mostly use IMRPhenomPv2/D and other older waveforms. We want to move towards having more recent waveforms in the test suite.

(See discussion: https://git.ligo.org/lscsoft/bilby/-/merge_requests/1268#note_950758)
@GregoryAshton
Copy link
Collaborator

GregoryAshton commented Oct 7, 2024 •
edited
Loading

Suggest that we replace IMRPhenomPv2 with IMRPhenomXPHM and IMRPhenomD with IMRPhenomXAS and assign this to Ann Malz @akjm99.

@GregoryAshton GregoryAshton self-assigned this Oct 7, 2024
@akjm99 akjm99 linked a pull request Jan 29, 2025 that will close this issue
TST: change all likelihood and waveform tests to use more recent waveforms (#791) #897
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoryAshton GregoryAshton

@akjm99 akjm99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST: change all likelihood and waveform tests to use more recent waveforms (#791) akjm99/bilby
3 participants
@GregoryAshton @akjm99 @bilby-bot