Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guidelines to explain how to update a PR with changes from main #901

Open
mj-will opened this issue Feb 4, 2025 · 0 comments
Open

Update contributing guidelines to explain how to update a PR with changes from main #901

mj-will opened this issue Feb 4, 2025 · 0 comments
Labels
documentation A change to docstrings or doc pages

Comments

@mj-will
Copy link
Collaborator

mj-will commented Feb 4, 2025

The current contributing guidelines do not described how to update a PR with changes from main.

This is particularly relevant when, for example, the CI breaks for an unrelated reason and one needs to update the PR to include an unrelated fix.

This can be done via either a merge or rebase, we should decide which we prefer and document it.
@mj-will mj-will added the documentation A change to docstrings or doc pages label Feb 4, 2025
@mj-will mj-will changed the title Update contributing guidelines to explain how to update a PR with changes from main. Update contributing guidelines to explain how to update a PR with changes from main Feb 4, 2025
@mj-will mj-will mentioned this issue Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation A change to docstrings or doc pages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mj-will