Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules to check into IzzyOnDroid #6

Open
8 of 10 tasks
binarynoise opened this issue Dec 30, 2023 · 9 comments
Open
8 of 10 tasks

New modules to check into IzzyOnDroid #6

binarynoise opened this issue Dec 30, 2023 · 9 comments

Comments

@binarynoise
Copy link
Owner

binarynoise commented Dec 30, 2023

Hi @IzzySoft,
@programminghoch10 and I worked on and added some new modulets.
Would you add the new ones to your repo?

  • com.programminghoch10.AntiBrightnessChange
  • com.programminghoch10.MotionEventMod
  • com.programminghoch10.RotationControl
  • de.binarynoise.AutomaticAdvancedSettingsExpander
  • de.binarynoise.betterBluetoothDeviceSort
  • de.binarynoise.betterVerboseWiFiLogging
  • de.binarynoise.dontResetIfBootedAndConnected
  • de.binarynoise.freeNotifications
  • de.binarynoise.muteSlf4jWarnings
  • de.binarynoise.openWifiOnTop
  • de.binarynoise.resetAllNotificationChannels

  • added to the repo
  • not added to the repo yet
  • not to be added to the repo
@IzzySoft
Copy link

Would be nice if your Fastlane could include an icon for each module. Quick idea: the standard Xposed icon with a symbol embedded, e.g. the standard brightness symbol wtih AntiBrightnessChange, rotation symbol with RotationControl etc. Not the nicest ones admittedly, but if you like them:

icon_bluetooth
icon_brightness
icon_rotate
icon_settings
icon_wifi

In case you want to edit them, or build upon it (e.g. for the other modules), here's the multi-layer Gimp file: xposed_icons.xcf.zip. I have no idea why in the browser, the background of the puzzle piece is gray; it's white with 25% opacity and an image viewer also shows it as such. If you prefer it entirely transparent, just select the other "piece" layer in the Gimp file and export again. Or fill it with a different color, e.g. a decent and not too bright yellow (complement to the blue).

  • com.programminghoch10.RotationControl: full_description is just a copy of short_description. Can you please update that similar to com.programminghoch10.AntiBrightnessChange?
  • de.binarynoise.muteSlf4jWarnings: Fastlane directory is empty, need metadata before I can add this 😉

@IzzySoft
Copy link

IzzySoft commented Dec 31, 2023

PS: com.programminghoch10.RotationControl gives me the following whenever I create a new index here:

ResourceType W 12-31 15:19:54 3200440 3200440] No known package when getting value for resource number 0x0108004d
ResourceType W 12-31 15:19:54 3200440 3200440] No known package when getting value for resource number 0x0108004d
AndroidManifest.xml:11: error: ERROR getting 'android:icon' attribute: attribute value reference does not exist

(just with different time stamps, which reflect the time fdroid update was run). Can you please check and fix that? It's otherwise spamming me constantly 🙈

Edit: I guess the last line is caused by this

    <application
        android:icon="@android:drawable/ic_menu_rotate"
        android:label="RotationControl"
        >

referencing something that's not defined as there's no corresponding file in resources (not even any directory for drawables). Comparing to some other module, I'd say removing android:icon="@android:drawable/ic_menu_rotate" from the manifest should solve that (adding the resource would solve it, too 😉). The two lines above could be follow-up errors (identical resource numbers, and 1 resource missing would match that).

@binarynoise
Copy link
Owner Author

I uploaded a version of RotationControl that has the icon removed, did this fix your issue with publishing?

I will have a look at creating the icons.

@IzzySoft
Copy link

IzzySoft commented Jan 1, 2024

I uploaded a version of RotationControl that has the icon removed, did this fix your issue with publishing?

Checking now … iod repo get com.programminghoch10.RotationControl successful … iod repo fdu running … done. Confirmed, looks good – thanks!

I will have a look at creating the icons.

Wonderful!

@BRBsoup
Copy link

BRBsoup commented Aug 8, 2024

Probably would be cool to state that they're xPosed modules in the descriptions :)

@IzzySoft
Copy link

IzzySoft commented Aug 8, 2024

They are in the "Xposed" category, no?

@cooldroid

This comment was marked as off-topic.

@IzzySoft

This comment was marked as off-topic.

@binarynoise
Copy link
Owner Author

state that they're xPosed modules in the descriptions

Yeah, this might be a good idea. I'll add it with the next update if I don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants