Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pattern curation and add regex checking to resolver #59

Open
cthoyt opened this issue May 31, 2020 · 1 comment
Open

Improve pattern curation and add regex checking to resolver #59

cthoyt opened this issue May 31, 2020 · 1 comment
Assignees

Comments

@cthoyt
Copy link
Member

cthoyt commented May 31, 2020

This should have been obvious since the patterns are available for most. Regex checking isn't strictly necessary if the id mapping is loaded, but can provide more information to users. It can also help catch cases where we would want to make an identifiers.org URL but there's no id->name mapping available already

Possible cases to handle:

  • some namespaces don't have patterns but do have identifiers... should warn me as the developer to get curating (pattern and sample ID should go in the metaregistry)
  • some namespaces have a pattern written in the metaregistry (ensure there's a sample ID)
  • Add optional field in metaregistry for decoy identifiers
  • some namespaces have a pattern just in MIRIAM

See also:

@cthoyt cthoyt self-assigned this May 31, 2020
@cthoyt
Copy link
Member Author

cthoyt commented Feb 24, 2023

throwback before we made bioregistry ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant