Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility #7

Open
djmtype opened this issue Dec 10, 2020 · 2 comments
Open

Accessibility #7

djmtype opened this issue Dec 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@djmtype
Copy link

djmtype commented Dec 10, 2020

Please add keyboard and screenreader support.
@birjj
Copy link
Owner

birjj commented Dec 11, 2020

This is definitely an area to improve. That being said, could you please be a bit more specific? Keyboard support should already be implemented (Esc closes the lightbox, ← and → navigate in albums). If that is not working, that's an issue that should be reported separately.

@birjj birjj added the enhancement New feature or request label Dec 11, 2020
@djmtype
Copy link
Author

djmtype commented Dec 11, 2020

Using a keyboard to navigate, images aren't naturally focused elements like links or buttons. Therefore, it's impossible to trigger the lightbox via keyboard. Adding a tabindex to images isn't a good idea either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djmtype @birjj