Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync on collection update #1240

Open
wants to merge 4 commits into
base: main-ose
Choose a base branch
from

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 14, 2025

Purpose

Nice to have for:

Short description

  • Pass account of the changed collection along when notifying listeners of collections change.
  • Then have SyncWorkerManager listen to any collection changes and use the account passed along to trigger a one time sync of the whole account (not just the service which the collection belongs to - although that would prob be possible as well).

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup requested a review from ArnyminerZ January 14, 2025 15:23
@sunkup sunkup marked this pull request as ready for review January 14, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically sync when collections are (un)checked "Force read-only" setting not effective immediately
1 participant