Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple sources with same name aren't shown. [OBS] #164

Open
2 tasks done
lindenkron opened this issue Sep 7, 2022 · 4 comments
Open
2 tasks done

[BUG] Multiple sources with same name aren't shown. [OBS] #164

lindenkron opened this issue Sep 7, 2022 · 4 comments
Labels
Needs Companion Support Needs support from Companion before it can be implemented

Comments

@lindenkron
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

If you have multiple sources that are identical, but placed different places in OBS - you cannot interact with them in companion. Having more than one source of same name breaks companion.

I'm guessing you're importing based on name, instead of source ID which should be unique, which name isn't.

Steps To Reproduce

  1. Create a scene.
  2. Create an image source.
  3. Name it 'Image'
  4. Copy paste source multiple times.
  5. Open Companion.

Only one source appears. You cannot toggle it because this breaksa it.

Expected Behavior

It should import each image source, so you can individually manage them and toggle them.

Environment (please complete the following information)

- OS: Windows 10
- Browser: Chrome/Firefox
- Companion Version: 2.3.0 (2.3.0+4608-v2-3.0-2994a6d0)

Additional context

No response

@lindenkron lindenkron added the Bug Issue or broken item within the module label Sep 7, 2022
@Julusian Julusian transferred this issue from bitfocus/companion Sep 7, 2022
@bryce-seifert
Copy link
Member

bryce-seifert commented Sep 8, 2022

@lindenkron Can you give this a try in the latest Companion beta and OBS 28?

I see that it toggles all sources of the same name in the selected scene, but I don't see any "breaking" occurring.

We currently use scene + source name instead of scene + scene item ID since it's more intuitive to setup. Is there a use case for having sources of the same exact name in the same scene? Can this be overcome by renaming the source to distinguish them?

@lindenkron
Copy link
Author

lindenkron commented Sep 8, 2022

@lindenkron Can you give this a try in the latest Companion beta and OBS 28?

I see that it toggles all sources of the same name in the selected scene, but I don't see any "breaking" occurring.

We currently use scene + source name instead of scene + scene item ID since it's more intuitive to setup. Is there a use case for having sources of the same exact name in the same scene? Can this be overcome by renaming the source to distinguish them?

Strange. When I tried to toggle, it would toggle off/on (depending on existing state) and then stop doing anything. I suppose false behavior may vary.

  • For larger productions/setups that include a lot of duplication work it's often easier due to everything being literally identical.
  • When upgrading existing setup (like going from Elgato, where this works, to Companion).

It'll probably work using a unique source name, but it seems strange to me that the user needs to be aware of this. OBS treats sources based on their unique ID due to having this functionality - and it seems like something a plugin/module should adhere to, for functionality compatibility.

(Also sorry for putting the report in the wrong section!)

@bryce-seifert
Copy link
Member

Looking at the Elgato Plugin, it seems like Source Visibility has a scene dropdown, and then based on the selected scene filters to show only that scene's sources in the Source dropdown.

This is similar behavior as to what is requested in bitfocus/companion#1635

I think if this becomes a core feature, we could implement a similar mechanism for the module. For now our limitation is the dropdown displays all sources, regardless of scene, so differentiating by scene item ID is hard to do in readable way.

@lindenkron
Copy link
Author

Looking at the Elgato Plugin, it seems like Source Visibility has a scene dropdown, and then based on the selected scene filters to show only that scene's sources in the Source dropdown.

This is similar behavior as to what is requested in bitfocus/companion#1635

I think if this becomes a core feature, we could implement a similar mechanism for the module. For now our limitation is the dropdown displays all sources, regardless of scene, so differentiating by scene item ID is hard to do in readable way.

I don't know if you looked at v28 (StreamDeck 2.0), or (StreamDeck) v27. Just a quick note that v28 (StreamDeck 2.0) is currently having issues with this multi source thing as well.

They used to have the issue in v27 (StreamDeck) but it got fixed and I've not experienced issues getting my sources for a while. Which is also why I ended up here, hoping to make a switch to Companion that would allow me to move to OBS v28 :)

I'm glad to hear other's have had similar requests and that I'm not alone in this!

Thanks for taking a look at it.

@bryce-seifert bryce-seifert added Needs Companion Support Needs support from Companion before it can be implemented and removed Bug Issue or broken item within the module labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Companion Support Needs support from Companion before it can be implemented
Projects
None yet
Development

No branches or pull requests

2 participants