You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, this is just an idea. Feel free to discard it, if it's stupid.
Yesterday I was working on a little PR in bevy (bevyengine/bevy#17545). I made a totally stupid rookie mistake and entered angles in degrees instead of radians in Quat::from_axis_and_angle.
It got me thinking: Would it be an option to rename the angle parameter to radians? I think it would make things more explicit and in some scenarios it could potentially be the one little extra hurdle that prevents a mistake like mine, since:
the names are displayed in rendered doc comments in most editors
the names are pre-filled when auto completing functions in some editors
Anyways, if you don't like it, feel free to close this issue without any second thoughts. I'll open a PR for this. Feel free to close it as well if you don't like the idea.
The text was updated successfully, but these errors were encountered:
Hey, this is just an idea. Feel free to discard it, if it's stupid.
Yesterday I was working on a little PR in bevy (bevyengine/bevy#17545). I made a totally stupid rookie mistake and entered angles in degrees instead of radians in
Quat::from_axis_and_angle
.It got me thinking: Would it be an option to rename the
angle
parameter toradians
? I think it would make things more explicit and in some scenarios it could potentially be the one little extra hurdle that prevents a mistake like mine, since:Anyways, if you don't like it, feel free to close this issue without any second thoughts. I'll open a PR for this. Feel free to close it as well if you don't like the idea.
The text was updated successfully, but these errors were encountered: